API review

Proposer: Josh F

Present at review:

  • List reviewers

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Patrick

This all looks fine, but it's a pretty minimal subset of what Eigen has (although Eigen only cares about 16-byte alignment). Is this intentional or should we consider adding other features?

An easy addition would be aligned new and delete functions:

   1 template<typename T> alignedNew(size_t size, size_t alignment);
   2 
   3 template<typename T> alignedDelete(T *ptr, size_t size);

Eigen also goes to some trouble to support explicitly aligned types - for example in GCC, declared with __attribute__ ((aligned (16))).

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

  • /!\ Action items that need to be taken.

  • {X} Major issues that need to be resolved

  • Extra features will be considered for the future, but for now allocators is sufficient for supporting lockfree and rosrt.


Wiki: allocators/Reviews/2010-05-27_API_Review (last edited 2010-06-04 20:41:08 by JoshFaust)