API review

Proposer: Eric Berger

Present at review:

• Brian Gerkey
• Tully

PowerBoardState.msg

http://www.ros.org/doc/api/pr2_msgs/html/msg/PowerBoardState

• Not yet reviewed (as far as I could find documentation)
• Tully
  • The runstop button flag should be commented as to the fact that it is unobservable when the remote runstop is pressed.

PressureState.msg

http://www.ros.org/doc/api/pr2_msgs/html/msg/PressureState

• Not yet reviewed
• Brian:
  • Need documentation on the two arrays in that message. What are the units? Any info on the ordering of the values in each array? Is int16 the appropriate type?

AccelerometerState.msg

http://www.ros.org/doc/api/pr2_msgs/html/msg/AccelerometerState

• Not yet reviewed
• Brian:
  • Need documentation on the Vector3 array in that message. What are the units? Any info on the ordering of the values?

PowerState.msg

http://www.ros.org/doc/api/pr2_msgs/html/msg/PowerState

• Not yet reviewed
• Tully:
  • Power consumption direction needs to be defined. Is it into the batteries or into the system.

Message in package that don't need review

BatteryServer.msg

Deprecated in response to previous review. Will be removed before 1.0

BatteryState.msg

Deprecated in response to previous review. Will be removed before 1.0

BatteryServer2.msg

reviewed at http://www.ros.org/wiki/ocean_battery_driver/Reviews/2009-11-13%20API%20Review

BatteryState2.msg

reviewed at http://www.ros.org/wiki/ocean_battery_driver/Reviews/2009-11-13%20API%20Review

DashboardState.msg

This is still under development - don't consider this to be an exported API

AccessPoint.msg

This is still under development - don't consider this to be an exported API

LaserTrajCmd.msg, LaserScannerSignal.msg, PeriodicCmd.msg

Plus associated services

Messages were discussed and accepted at http://www.ros.org/wiki/pr2_mechanism_controllers/Reviews/2009-12-09%20LaserController_API_Review

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved