API review

Proposer: Kevin

Present at review:

  • Kevin
  • JFaust
  • James
  • Blaise

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Blaise

  • Configure pub rate?
    • /!\ Add parameter in aggregator constructor to allow pub rate to be configured (X)

  • /!\ Make Analyzer a pure virtual class (X)

  • /!\ Put list/string extraction stuff in GenericAnalyzer init into one place (X)

bool getParamVals(string param_name, vector<string> &output)
  • /!\ Use DiagnosticStatusWrapper if necessary. Not needed now, but could be useful for others. Avoids users doing stringstream (Not yet, we'll see)

  • /!\ Something about optimizing (Not yet, not API)

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

  • /!\ Action items that need to be taken.

  • {X} Major issues that need to be resolved


Wiki: diagnostic_aggregator/Reviews/2009-11-2_API_Review (last edited 2009-11-02 21:15:51 by KevinWatts)