API review

Proposer: Wim Meeussen

Present at review:

• List reviewers

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Tully

• CodeAPI link goes to blank page. It should redirect to msg APIs. Maybe just a link in the mainpage.
• odometer in linear joint is ambiguous (aka should be meters not radians)
• Justify/document these fields presence

# ?
int32 device_id

# ?
byte calibration_reading
byte calibration_rising_edge_valid
byte calibration_falling_edge_valid
float64 last_calibration_rising_edge
float64 last_calibration_falling_edge

# flag to indicate if this actuator is enabled or not. 
# An actuator can only be commanded when it is enabled.
byte is_enabled

# ?
byte run_stop_hit

• WTF is BufferedData*?

• Two copies of switch controller action messages? and a service?

• consider consolidating ListControllers and ListControllerTypes

• get rid of usages of byte for bool where proper(likely most places)

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved