API review

Proposer: Kevin

Present at review:

  • Kevin
  • Eric
  • Curt
  • Tully

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.



I'd like to add two fields to the power board state message to show the temperature and base fan speed. This will allow us to set and check the power board fan speed easily.

I would also like to add a field to report the last update of the power board. I want to have this field in case we are unable to contact the power board. Currently, if we're unable to contact the power board, the power node publishes empty data. If we have a field for "time_since_update" or "last_update", we can determine if the data is valid. I'm proposing a ros::Time value, but I'm open to a Duration, or even a bool for "invalid". See <<Ticket(wg-ros-pkg 3877)>>.

Proposed addition:

uint32 temperature # Temperature in degrees C
uint32 fan_speed # RPM of fan speed
time last_update # Last update from the power board

Meeting agenda

To be filled out by proposer based on comments gathered during API review period


We decided not to take action on this API change. <<Ticket(wg-ros-pkg 3877)>> will be closed, no messages changed.

Package status change mark change manifest)

  • /!\ Action items that need to be taken.

  • {X} Major issues that need to be resolved

Wiki: pr2_msgs/Reviews/2010-09-29 API Review API Review (last edited 2010-10-06 22:45:58 by KevinWatts)