API review

Proposer: Brian Gerkey

Present at review:

• List reviewers:
  • Jeremy Leibs

We're reviewing the newly proposed rosdistro API: rosdistro/NewAPI

Question / concerns / comments

Enter your thoughts on the API and any questions / concerns you have here. Please sign your name. Anything you want to address in the API review should be marked down here before the start of the meeting.

Jeremy

• I'm somewhat confused as to how this relates to the assorted ros environment variables: e.g., ROS_ROOT, ROS_PACKAGE_PATH. Do these get put in an approprate setup.bash script that goes in <path>?

• The fact that install-stack always takes a <path> feels like it may be an annoyance. Can <path> somehow be stored in your environment variable so that this isn't necessary? I would expect interaction along the lines of:

  • . ~/myrosinstall/setup.bash
    rosdistro install-stack somestack

• How does the interaction with <local-path> work?

  • Are you responsible for adding <local-path> to the front of ROS_PACKAGE_PATH manually?

  • If you make changes to a stack that something depends on, what is the right way to trigger the appropriate rebuild of everything that depends on it? Should those dependent stacks be installed to <local-path> as well?

  • If you do an upgrade after modifying your ROS_PACKAGE_PATH to include <local-path>, do these upgraded packages get built against the local, or the installed version?

• Why does uninstall-stack talk about an an installation-location? Is this for uninstalling from your main install vs. uninstalling from <local-path>?

Tully

• I too am a little worried that there's a lot of <path>s to type. I would like to have it be an "option" which can override an environment variable. And it will complain if neither is set.

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved