roslib API review

Proposer: Ken Conley

Present at review:

• List reviewers

Question / concerns / comments

Tully

• The rostime part which was integrated has already cleared API

Josh

• roslib::manifest::getText, roslib::manifest::isLegalPackageName are the only camelcased functions in that namespace
  • fixed (getText was made _get_text, ieLegal... was deleted)

Brian

• Use either package or pkg, but not both, in method names: http://pr.willowgarage.com/pr-docs/ros-packages/roslib/html/namespaceroslib_1_1packages.html

• Use either deps or depends, but not both: http://pr.willowgarage.com/pr-docs/ros-packages/roslib/html/namespaceroslib_1_1scriptutil.html

• It would be nice to exclude or at least mark as internal underscored methods, e.g.: http://pr.willowgarage.com/pr-docs/ros-packages/roslib/html/namespaceroslib_1_1msgs.html

Meeting agenda

To be filled out by proposer based on comments gathered during API review period

Conclusion

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved

Done:

• package -> pkg

• deps -> depends

Passed!