API review

Proposer: Tully Foote

Present at review:

• List reviewers

Question / concerns / comments

Proposed changes

• replacing -r/-k with best effort --build-all gets current -r -k flags.
• add environment variable to override "make" with "gmake" for FreeBSD

Current usage

rosmake -h
Usage: rosmake [options] COMMAND PACKAGE LIST

Options:
  -h, --help            show this help message and exit
  --test-only           only run tests
  -t                    build and test packages
  -a, --all             select all packages
  -i, --mark-installed  On successful build, mark packages as installed with
                        ROS_NOBUILD
  -u, --unmark-installed
                        Remove ROS_NOBUILD from the specified packages.  This
                        will not build anything.
  -v                    display errored builds
  -r, -k, --robust      do not stop build on error
  -V                    display all builds
  -s, --specified-only  only build packages specified on the command line
  --buildtest=BUILDTEST
                        package to buildtest
  --buildtest1=BUILDTEST1
                        package to buildtest1
  --output=OUTPUT_DIR   where to output results
  --pre-clean           run make clean first
  --disable-logging     turn off all logs
  --target=TARGET       run make with this target
  --pjobs=ROS_PARALLEL_JOBS
                        run make with this N jobs '-j=N'
  --threads=THREADS     Build up to N packages in parallel
  --profile             print time profile after build
  --skip-blacklist      skip packages containing a file called
                        ROS_BUILD_BLACKLIST (Default behavior will ignore the
                        presence of ROS_BUILD_BLACKLIST)
  --skip-blacklist-osx  skip packages containing a file called
                        ROS_BUILD_BLACKLIST_OSX (Default behavior will ignore
                        the presence of ROS_BUILD_BLACKLIST_OSX)
  --rosdep-install      call rosdep install before running
  --rosdep-yes          call rosdep install with default yes argument
  --no-rosdep           disable the default check of rosdep

Meeting agenda

Conclusion

Package status change mark change manifest)

• Action items that need to be taken.

• Major issues that need to be resolved

• add -R with current semantics
• replace current -r/-k with best effort
• confirm "MAKE" is the default for overrideing "make"
• make sure there's an env flag for threads ROS_MAKE_THREADS
• if user specifies it take integer, and override environment
• ticket for future: adding rosmake.rc or default arguments environment variable to have default flags for rosmake
• change default to not call rosdep if it cannot be fast enough to not annoy people(josh)
• add whitelist and whitelist recursive options