API review

Proposer: Wim Meeussen

Present at review:

• Vijay

Question / concerns / comments

• Do the msgs and srvs in the Package belong here or in a higher/lower level Package?

• Are all msgs appropriate semantic, e.g. (FourFloat64 vs. Quaternion)

• Are all srvs have method-like rather than data-type names, e.g. (SetMap vs. Map)

Vijay

• Looking at smach_msgs/SmachContainerStatus, it seems a bit odd to have a completely ambiguous field

  # Some arbitrary info
  string info

• I don't know much about smach, but everything else seems reasonable.

Conclusion